Re: ra_serf/ra_neon/ra_svn comparison

On Sun, Aug 3, 2008 at 8:52 AM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> Daniel Shahaf wrote:
>>
>> I was about to commit the latest patch, but then I thought to see what
>> ra_serf does. (A little late, I know.)
>>
>> ra_serf, like ra_svn (and unlike ra_neon), currently reports the totals,
>> not the deltas (see svn_ra_serf__progress and serf_context_progress_delta).
>>
>> Any ideas how to make all three ra layers consistent? Given that two
>> different ra layers implemented the "wrong" (= different from neon's)
>> (but, IMHO, consistent with the docstring) semantics, I don't think we
>> can just ignore that and change svn_ra_progress_notify_func_t's doc
>> string now.
>
> I don't mind changing it, as long as it is consistend over all layers.
> But for ra_neon, this would require a change in the neon library. And I'm
> not sure, but I think that progress notifications for ra_serf were also not
> available in 1.4 yet, while neon had this from 1.3 on.

I think that they should all be made consistent with Neon and if the
docstring needs to be fixed, then fix that too.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org