Re: One line patch for Korean translation (ko.po)

Jens Seidel wrote on Sat, 26 Jul 2008 at 15:20 +0200:
> On Sat, Jul 26, 2008 at 03:58:38PM +0300, Daniel Shahaf wrote:
> > Jens Seidel wrote on Sat, 26 Jul 2008 at 14:44 +0200:
> > > indeed. I fixed it in trunk and in the 1.5.x branch. Thanks a lot!
> > Jens, just to clarify, do you speak Korean?
>
> No.
>
> Nevertheless I know many translation teams (across many projects) and it
> never happened that one person just sent in a fake message for fun.
>

Presumably because these other teams won't apply a change before it has
been read by someone who understands it? That's the same reason people
don't send us

     @@ -17,1 +17,2 @@
      main() {
     + abort();

patches --- they know the patches won't be applied before being read by
someone who knows C.

> If the previous translator will be active again he should check the
> changes (the diff is readable, I committed the update and the fix
> separately).
>
> I'm also sure there is no rule which requests that a translation
> requires a proofread by an offical person before the commit. Otherwise
> it would be very hard to add new translations ...
>

There is a rule that says you shouldn't commit a change just because you
think it's likely to be correct. HACKING says:

    Voting +1 on a change doesn't just mean you approve of it in principle.
    It means you have thoroughly reviewed the change, and find it correct
    and as nondisruptive as possible.

and (IMHO) it applies equally to committing and to voting.

>

Personally, I think you should not have committed r32303:r32306, and
(unless translations are exempt from the criterion I quoted) I think
they should be reverted or blessed by someone who speaks Korean.

Then, if Kang Jeong-Hee wants to maintain the Korean translation, we
should give him commit access, not commit his patches carte blanche.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-26 16:55:11 CEST