David Glasser wrote:
> On Thu, Jul 24, 2008 at 10:32 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>> David Glasser wrote:
>>> On Thu, Jul 24, 2008 at 6:10 PM, C. Michael Pilato <cmpilato_at_collab.net>
>>> wrote:
>>>> Branko Čibej wrote:
>>>>> C. Michael Pilato wrote:
>>>>>> It was just brought to my attention that I *should* have seen serf
>>>>>> tests
>>>>>> failing.
>>>>> Can someone please remind me why those two serf tests aren't XFAIL?
>>>> Because the tests can't reliably know which of the two WebDAV modules is
>>>> being used?
>>> Sure it can; it can check svntest.main.http_library.
>>>
>>> Now, sure, you're only "required" to pass --http-library
>>> ($HTTP_LIBRARY) to the test suite if you've built with both libraries,
>>> but we can change that requirement. (Or it can just parse 'svn
>>> --version'.)
>> Right. So, no, it cannot reliably work today to simply mark those test as
>> XFAIL based on some readily-available conditional evaluation. But yes,
>> there are things we can do to our testing framework to make this possible.
>
> I mean, the "thing" we do is add a line to the README which says "when
> testing with serf, set the HTTP_LIBRARY variable (if running with make
> check) or pass --http-library (if running directly)".
README, sure. Not really so visible, though.
Another option: we make the test suite require --http-library if the --url
parameter indicates we're using DAV. Though perhaps mildly annoying to
folks running tests by hand, I think a clear requirement and equally clear
error message ("You must specify either --http-library=serf or
--http-library=neon") would go a lot further towards actual benefit and utility.
--
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on 2008-07-25 18:01:38 CEST