[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Aborts on Windows [was: svn 1.5 commit fails]

From: Bert Huijben <bert_at_vmoo.com>
Date: Wed, 23 Jul 2008 23:22:14 +0200

> -----Original Message-----
> From: Stefan Küng <tortoisesvn_at_gmail.com> [mailto:=?ISO-8859-
> 1?Q?Stefan_K=FCng_<tortoisesvn_at_gmail.com>?=]
> Sent: woensdag 23 juli 2008 21:06
> To: dev_at_subversion.tigris.org
> Subject: Re: Aborts on Windows [was: svn 1.5 commit fails]
>
> Julian Foad wrote:
> > On Wed, 2008-07-23 at 18:58 +0200, Stefan Küng wrote:
> >> Hi,
> >>
> >> a simple
> >>
> >> $ svn ci folder1 folder2 -m ""
> >>
> >> crashes if the working copy is in the root drive.
> >>
> >> To reproduce:
> >> $ SUBST g: d:\development\myworkingcopy
> >> $ cd g:
> >> $ svn ci folder1 folder2 -m ""
> >> This application has requested the Runtime to terminate it in an
> unusual
> >> way. Please contact the application's support team for more
> information.
> >>
> >> The reason for this is in subversion\libsvn_client\commit.c, line
> 1555
> >>
> >> Did I mention before that I really hate abort() calls? Instead of
> >> getting a usable crashdump which could have given me enough
> information
> >> to get a reproduction recipe, I got nothing. After several mails
> spread
> >> over several days I was finally able to get a reproduction recipe
> from a
> >> user who had this problem.
> >
> > You did mention before :-)

We see a few replaced abort()s per week on the AnkhSVN 2.0 error report
list. Since we only released 2.0 about two weeks ago this number will
probably grow over the next few weeks. All via svn_client_commit4()
(No usable reports yet for tracing the error, but the issue seems to be
reproducible for some users (with a few days in between))

I globally replaced the abort calls in subversion 1.5.0 by a call into c++
and throw an exception there, that eventually (several layers above the call
into subversion) is handled in a Visual Studio error handler.

We can't install a crash handler or allow crashing completely in Visual
Studio. (Too much source code to lose)

        Bert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-23 23:22:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.