[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Aborts on Windows [was: svn 1.5 commit fails]

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 23 Jul 2008 21:06:26 +0200

Julian Foad wrote:
> On Wed, 2008-07-23 at 18:58 +0200, Stefan Küng wrote:
>> Hi,
>>
>> a simple
>>
>> $ svn ci folder1 folder2 -m ""
>>
>> crashes if the working copy is in the root drive.
>>
>> To reproduce:
>> $ SUBST g: d:\development\myworkingcopy
>> $ cd g:
>> $ svn ci folder1 folder2 -m ""
>> This application has requested the Runtime to terminate it in an unusual
>> way. Please contact the application's support team for more information.
>>
>> The reason for this is in subversion\libsvn_client\commit.c, line 1555
>>
>> Did I mention before that I really hate abort() calls? Instead of
>> getting a usable crashdump which could have given me enough information
>> to get a reproduction recipe, I got nothing. After several mails spread
>> over several days I was finally able to get a reproduction recipe from a
>> user who had this problem.
>
> You did mention before :-)
>
> Have you tried the replacement for abort() which is now on the trunk?
> The line above has changed to:
>
> SVN_ERR_ASSERT((target[0] != '\0') &&
> !svn_dirent_is_root(target,
> strlen(target)));
>
> This by default calls svn_error_abort_on_malfunction(), which reports a
> Subversion error via svn_handle_error2(). If that's still not good and
> you need it to do something different on Windows to be helpful, let us
> know what that is and we can put it in.

Thanks for the info. Yes I think the changes on trunk will help a lot in
such situations.

Could you reproduce the problem I mentioned?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-07-23 21:06:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.