[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32145 - trunk/subversion/libsvn_subr

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 21 Jul 2008 14:10:08 -0400

Senthil Kumaran S <senthil_at_collab.net> writes:
> kfogel_at_tigris.org wrote:
>> /* File provider */
>> /*-----------------------------------------------------------------------*/
>>
>> -/* The keys that will be stored on disk */
>> -#define SVN_AUTH__AUTHFILE_USERNAME_KEY "username"
>> -#define SVN_AUTH__AUTHFILE_PASSWORD_KEY "password"
>> -#define SVN_AUTH__AUTHFILE_PASSTYPE_KEY "passtype"
>> +/* The keys that will be stored on disk; analogous to similar
>> + constants in ssl_client_cert_pw_providers.c and
>> + ssl_server_trust_providers.c. */
>
> We can simply say "analogous to similar constants in other providers." since
> username_providers.c also has such a constant (IMHO we should not list all the
> files which has such constants in the doc string).

Yeah, you're right, that would be a much better way. Done in r32205.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-21 20:10:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.