Re: svn commit: r32145 - trunk/subversion/libsvn_subr

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Karl,

kfogel_at_tigris.org wrote:
> /* File provider */
> /*-----------------------------------------------------------------------*/
>
> -/* The keys that will be stored on disk */
> -#define SVN_AUTH__AUTHFILE_USERNAME_KEY "username"
> -#define SVN_AUTH__AUTHFILE_PASSWORD_KEY "password"
> -#define SVN_AUTH__AUTHFILE_PASSTYPE_KEY "passtype"
> +/* The keys that will be stored on disk; analogous to similar
> + constants in ssl_client_cert_pw_providers.c and
> + ssl_server_trust_providers.c. */

We can simply say "analogous to similar constants in other providers." since
username_providers.c also has such a constant (IMHO we should not list all the
files which has such constants in the doc string).

> Modified: trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c?pathrev=32145&r1=32144&r2=32145
> ==============================================================================
> --- trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c Wed Jul 16 11:59:02 2008 (r32144)
> +++ trunk/subversion/libsvn_subr/ssl_client_cert_pw_providers.c Wed Jul 16 12:17:44 2008 (r32145)
> @@ -36,22 +36,12 @@
> /* File provider */
> /*-----------------------------------------------------------------------*/
>
> -/* The keys that will be stored on disk. These are analogous to
> - *
> - * SVN_AUTH__AUTHFILE_ASCII_CERT_KEY
> - * SVN_AUTH__AUTHFILE_FAILURES_KEY
> - *
> - * in ssl_server_trust_providers.c.
> +/* The keys that will be stored on disk; analogous to similar
> + * constants in ssl_server_trust_providers.c and simple_providers.c.

Here too.

> Modified: trunk/subversion/libsvn_subr/ssl_server_trust_providers.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/ssl_server_trust_providers.c?pathrev=32145&r1=32144&r2=32145
> ==============================================================================
> --- trunk/subversion/libsvn_subr/ssl_server_trust_providers.c Wed Jul 16 11:59:02 2008 (r32144)
> +++ trunk/subversion/libsvn_subr/ssl_server_trust_providers.c Wed Jul 16 12:17:44 2008 (r32145)
> @@ -33,9 +33,10 @@
> /* File provider */
> /*-----------------------------------------------------------------------*/
>
> -/* The keys that will be stored on disk */
> -#define SVN_AUTH__AUTHFILE_ASCII_CERT_KEY "ascii_cert"
> -#define SVN_AUTH__AUTHFILE_FAILURES_KEY "failures"
> +/* The keys that will be stored on disk; analogous to similar
> + constants in ssl_client_cert_pw_providers.c and simple_providers.c. */
> +#define AUTHN_ASCII_CERT_KEY "ascii_cert"
> +#define AUTHN_FAILURES_KEY "failures"

and here.

If you feel the same please make use of the attached patch.

[[[
Fix doc string.

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
  (File provider): Do not list all the files where the file provider
   constants are present instead say "other providers".

* subversion/libsvn_subr/ssl_server_trust_providers.c
  (File provider): Same as above.

* subversion/libsvn_subr/simple_providers.c
  (File provider): Same as above.

Patch by: stylesen
]]]

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIfxCO9o1G+2zNQDgRAhs6AJ416cRr2pskr6EwFhLjoAQiZDDH3QCfZMIH
MWXWhsHXDtoG9viDBUOZXco=
=8Zf/
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org