> -------Original Message-------
> From: Blair Zajac <blair_at_orcaware.com>
> Subject: Re: svn commit: r32164 - trunk/subversion/bindings/swig/python/tests
> Sent: 17 Jul '08 12:51
>
> hwright_at_tigris.org wrote:
> > Author: hwright
> > Date: Thu Jul 17 12:49:29 2008
> > New Revision: 32164
> >
> > Log:
> > Fix a segfault in the python tests.
> >
> > The problem here is that we're using a pre-1.5 log message callback function
> > to call a pre-1.5 API. That's all well and good, except that the callback
> > doesn't really behave like it's pre-1.5. Instead, it attempts to convert the
> > incoming svn_client_commit_item2_t references to svn_client_commit_item3_t
> > references, which summarily results in a segfault.
> >
> > There might be a better, more complete solution to this problem, but that will
> > take more swig-fu than I can muster right now.
>
> Yeah, if one can still cause the core dump in Python code, we'll need one of our
> swig-experts to figure this out :)
>
> We should leave this test there for svn_client_commit_item2_t but commented out
> so when it gets fixed for real, we can enable it.
I'm a bit confused: I didn't actually remove any tests, just made it so the client library (correctly) interpreted the python-provided callback as compatible with svn_client_commit_item3_t structures. Which bits should be commented out?
-Hyrum
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-17 22:10:31 CEST