On Mon, 2008-07-07 at 16:24 -0400, Karl Fogel wrote:
> Julian Foad <julianfoad_at_btopenworld.com> writes:
> > Yes, it is a worthy goal in general. But do you have a particular
> > problem with this that's arisen recently? This format is (I believe)
> > mimicking what standard "diff" and probably CVS diff does, and the
> > information is useful to humans perusing a patch where the revision
> > numbers might be pretty meaningless to them (not everbody memorises
> > revision numbers like some of us do), and there may well be applications
> > that are colouring or otherwise parsing this output that might break.
> >
> > I would have thought it would be better to leave well alone at this
> > stage of development, unless and until an occasion arises when we are
> > overhauling the format of Subversion diff output anyway (e.g. if we
> > change it as part of "svn patch" work).
> >
> > Plenty of things are broken in "svn diff", and this isn't one of them.
> >
> > However, I'll only say -0 if you really want to change it.
>
> It makes commit emails somewhat harder to read, IMHO.
>
> However, we could just tweak the 'svnlook diff' output before putting it
> into the commit email, if we really wanted to. That would be a better
> solution, now that I think about it. So I take back my proposal; if I
> ever really get the itch, I'll write a patch for mailer.py.
Karl, apologies: I thought we were talking about the output from "svn
diff"; I hadn't realised the date is only printed by "svnlook diff" and
not by "svn diff". In "svn diff" the client library always provides its
own headers (which do not include the date) which override the diff
library's default headers (which do include the date).
That changes my attitude. It's not such a big deal to change it, plus it
would be making it more consistent with patches generated by "svn diff".
However, editing it within "mailer.py" is also a reasonable way to
approach it.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-07 22:56:00 CEST