Julian Foad <julianfoad_at_btopenworld.com> writes:
> Yes, it is a worthy goal in general. But do you have a particular
> problem with this that's arisen recently? This format is (I believe)
> mimicking what standard "diff" and probably CVS diff does, and the
> information is useful to humans perusing a patch where the revision
> numbers might be pretty meaningless to them (not everbody memorises
> revision numbers like some of us do), and there may well be applications
> that are colouring or otherwise parsing this output that might break.
>
> I would have thought it would be better to leave well alone at this
> stage of development, unless and until an occasion arises when we are
> overhauling the format of Subversion diff output anyway (e.g. if we
> change it as part of "svn patch" work).
>
> Plenty of things are broken in "svn diff", and this isn't one of them.
>
> However, I'll only say -0 if you really want to change it.
It makes commit emails somewhat harder to read, IMHO.
However, we could just tweak the 'svnlook diff' output before putting it
into the commit email, if we really wanted to. That would be a better
solution, now that I think about it. So I take back my proposal; if I
ever really get the itch, I'll write a patch for mailer.py.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-07 22:24:55 CEST