Re: blame can access NULL-pointer

Blair Zajac wrote:
> Arfrever Frehtes Taifersar Arahesis wrote:
>> 2008-07-02 18:19:45 Stefan Küng napisał(a):
>>> Hi,
>>>
>>> In file subversion\libsvn_client\blame.c, line 684 there is an assert:
>>>
>>> /* The callback has to have been called at least once. */
>>> assert(frb.last_filename != NULL);
>>>
>>> I just got a crash report for TSVN where this assert is being hit:
>>> the user passed a revision range which didn't touch the file to
>>> blame. So the callback was never hit.
>>>
>>> I suggest returning an error there, something like "nothing to blame
>>> for the specified revision range".
>>
>> Julian Foad fixed it in r31972.
>
> Stefan, can you come up with a reproduction recipe using the svn
> client? What URL and revision range did the user use?
>
> Even with r31972 it'll create an svn assertion error, which doesn't
> sound like the correct response, unless TSVN is doing something odd.

There is not much more info from the crash dump file than (slightly
change to protect the innocent):

svn_client_blame4() called with:
D:/x/x/src/x/x/DefaultTransactionManager.java, peg=WC, startrev=16500,
endrev=HEAD (translates later to 16549), diff-options=ignore all spaces
and eol, ignore-mime-type = true, include-merged-revs=true

the working copy path translates to the url:
https://192.168.x.x:8443/svn/x/x/x/src/x/x/DefaultTransactionManager.java

Of course, I'm not sure whether the assertion got hit because the
callback didn't get called: all I know from the crash dump is that the
frb.last_filename is NULL and I assumed from the comment that the only
way that could happen is because the callback wasn't called.

I'll try and contact the one who sent the crash dump to get more
information. But you should know that most don't answer to such mails.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net