Re: blame can access NULL-pointer

Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-07-02 18:19:45 Stefan Küng napisał(a):
>> Hi,
>>
>> In file subversion\libsvn_client\blame.c, line 684 there is an assert:
>>
>> /* The callback has to have been called at least once. */
>> assert(frb.last_filename != NULL);
>>
>> I just got a crash report for TSVN where this assert is being hit: the
>> user passed a revision range which didn't touch the file to blame. So
>> the callback was never hit.
>>
>> I suggest returning an error there, something like "nothing to blame for
>> the specified revision range".
>
> Julian Foad fixed it in r31972.

Stefan, can you come up with a reproduction recipe using the svn client? What
URL and revision range did the user use?

Even with r31972 it'll create an svn assertion error, which doesn't sound like
the correct response, unless TSVN is doing something odd.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-02 18:49:18 CEST