Re: [PATCH] Fix issue #2242.

Senthil Kumaran S wrote on Thu, 26 Jun 2008 at 12:05 +0530:
> Hi Daniel,
>
> Daniel Shahaf wrote:
> > > - if (str && str->data)
> > > + if (strcmp(str->data, username) == 0)
> > ^
> >
> > Can STR be NULL here? I prefer
> >
> > str = apr_hash_get(creds, SVN_AUTH__AUTHFILE_USERNAME_KEY,
> > APR_HASH_KEY_STRING);
> > if (str && strcmp(str->data, username) == 0)
> >
>
> I am attaching an updated patch along with this email based on your comments
> above.
>
> Thank You.
>

+1 to commit, assuming it passes 'make check'.

Thanks!

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-26 10:37:46 CEST