Re: [PATCH] Fix issue #2242.

Hi Daniel,

Daniel Shahaf wrote:
>> - if (str && str->data)
>> + if (strcmp(str->data, username) == 0)
> ^
>
> Can STR be NULL here? I prefer
>
> str = apr_hash_get(creds, SVN_AUTH__AUTHFILE_USERNAME_KEY,
> APR_HASH_KEY_STRING);
> if (str && strcmp(str->data, username) == 0)
>

I am attaching an updated patch along with this email based on your comments above.

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org