Re: parsing of boolean config options

Bernd Kreuss <prof7bit_at_googlemail.com> writes:
> subversion/libsvn_ra_neon/session.c around line 1240 and
> subversion/libsvn_ra_dav/session.c around line 846
>
> /* See if the user wants us to trust "default" openssl CAs. */
> trust_default_ca = svn_config_get_server_setting(
> cfg, server_group,
> SVN_CONFIG_OPTION_SSL_TRUST_DEFAULT_CA,
> "true");
>
> if (svn_cstring_casecmp(trust_default_ca, "true") == 0)
> {
> ne_ssl_trust_default_ca(sess);
> ne_ssl_trust_default_ca(sess2);
> }
>
> it compares the config value with the *string* "true" which does not
> take into account that it also could be "yes"/"no", "1"/"0", "on"/"off"

Fixed in r31836, and thanks for pointing it out.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-22 03:51:12 CEST