[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: multiple password prompts

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Tue, 17 Jun 2008 16:30:27 +0530


David Glasser wrote:
> On Sun, Jun 15, 2008 at 5:26 AM, Stefan Sperling <stsp_at_elego.de> wrote:
>> On Sat, Jun 14, 2008 at 01:49:51PM +0300, Daniel Shahaf wrote:
>>> Stefan Sperling wrote on Sat, 14 Jun 2008 at 12:30 +0200:
>>>> Do you have any idea what difference between the googlecode.com
>>>> setup and my setup could cause the prompt appear twice for you?
>>> Did you try to reproduce against googlecode.com? Did you try both serf
>>> and neon?
>> Neither.
>> I'd rather wait for David's reply before I continue poking in the dark.
> I was using Neon. I try not to learn details about how the WebDAV
> protocols work, at googlecode or elsewhere, because I find them
> revolting.

The attached patch fixes this. After looking into the
code(subversion/libsvn_subr/simple_providers.c), I could see we start with
may_save_password value as 'FALSE' in line number 257. If it is unchanged by
the if condition immediately following it and we are interactive the
may_save_password still remains 'FALSE'.

Look for the else condition at line number 297 which searches for any cached
items for this realm if not gets it via the plaintext_prompt_func. Once we get
the answer we mark the cached_answer boolean in this condition with
may_save_password which is still 'FALSE' for the conditions mentioned above,
which ultimately results in giving a false alarm that we didn have any cached
answers when we come into this code once again.

So in this else block it is perfectly safe to mark cached_answer to 'TRUE' in
order to avoid this multiple password prompts instead of relying on
may_save_password which will misbehave.

Fix multiple password prompts.

* subversion/libsvn_subr/simple_providers.c
   (svn_auth__simple_save_creds_helper): When we do not have any cached answers
    we need set cached answers to 'TRUE' instead of may_save_password

Patch by: stylesen

Thank You.

PS: Sorry for my poor explanation above with line numbers :(

Senthil Kumaran S

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-06-17 13:01:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.