Re: svn commit: r31622 - trunk/subversion/libsvn_repos

Stefan Sperling wrote on Tue, 10 Jun 2008 at 13:03 +0200:
> On Tue, Jun 10, 2008 at 01:14:22PM +0530, Kamesh Jayachandran wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Senthil,
> >
> > - - capabilities_string = "";
> > + strcpy(capabilities_string, "");
> >
> > You can not copy to such un-initialized location.
> >
> > May the fix could be
> > - - capabilities_string = "";
> > + capabilities_string = apr_pstrdup(pool, "");
>
> Heh, that's what I had originally :)
> Somewhere along the way of getting this fix in the strdup()
> was dropped.
>

My fault, I probably forgot to check for compiler warnings before
I committed.

> Applied in r31673.
>

Thanks everyone :)

Daniel
<bikeshed>(who thinks pstrdup("") is ugly)</bikeshed>

> Thanks,
> Stefan
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-10 18:27:36 CEST