[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31622 - trunk/subversion/libsvn_repos

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 10 Jun 2008 13:03:50 +0200

On Tue, Jun 10, 2008 at 01:14:22PM +0530, Kamesh Jayachandran wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Senthil,
>
> - - capabilities_string = "";
> + strcpy(capabilities_string, "");
>
> You can not copy to such un-initialized location.
>
> May the fix could be
> - - capabilities_string = "";
> + capabilities_string = apr_pstrdup(pool, "");

Heh, that's what I had originally :)
Somewhere along the way of getting this fix in the strdup()
was dropped.

Applied in r31673.

Thanks,
Stefan

  • application/pgp-signature attachment: stored
Received on 2008-06-10 13:05:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.