[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31583 - trunk/subversion/libsvn_wc

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 04 Jun 2008 17:09:52 -0400

Branko Čibej <brane_at_xbc.nu> writes:
> And it strikes my that far too much effort is being spent on stylistic
> nits lately. Yes, consistent style is important, but working code is
> more important.

Far too much effort is being spent lately pointing out how much effort
is being spent on stylistic nits...

Seriously: I don't see reviews where the patch is rejected solely for
stylistic nits. Do you? And I try to always make substantive code
comments along with stylistic ones, or when there are only stylistic
comments, I go out of my way to point out that the style questions are
not all that important. I see others doing similarly.

Gently enforcing stylistic consistency is a perfectly reasonable thing
for a project to do. If we were to do it in overeager and hard-nosed
ways -- ways that could waste reviewers' time or drive away potential
contributors -- then I'd think you were on to something. But, I don't
see any of that going on. Do you?

If there's an actual conflict between working code and stylistic nits,
then absolutely, we should favor working code. But the mere existence
of style comments does not mean there is such a conflict.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-04 23:10:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.