Re: [PATCH] 1.5.x branch: python/cmdline

Alexander Sinyushkin <Alexander.Sinyushkin_at_svnkit.com> writes:
> Ok, thank you. I'll try to take this piece of advice into account in
> the future.

Thanks.

I realized I misspoke a bit when I said:

>> Also, remember that the key thing is not length -- it's just that most
>> information should go in the code (as comments) instead of in the log
>> message.
>>
>> The log message should be an overview of the change: it prepares the
>> reviewer's mind for reading the code change, by explaining what
>> motivated the change and then briefly describing the overall shape of
>> the change. But detailed information should be in the change itself.

Well, in one sense the log message should be detailed: it should mention
every affected symbol, as described in hacking.html. But it doesn't
need to go into extreme detail about every aspect of the implementation,
especially not where code comments would be more appropriate.

Hope that clarifies, sorry for misstating it before.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-03 16:17:24 CEST