Re: [PATCH] 1.5.x branch: python/cmdline

Ok, thank you. I'll try to take this piece of advice into account in the
future.

----
Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!
Karl Fogel wrote:
> Lieven Govaerts <svnlgo_at_mobsol.be> writes:
>> As Daniel said, our log messages are normally a bit shorter ;) Just a
>> few of the key phrases should be sufficient.
> 
> Also, remember that the key thing is not length -- it's just that most
> information should go in the code (as comments) instead of in the log
> message.  
> 
> The log message should be an overview of the change: it prepares the
> reviewer's mind for reading the code change, by explaining what
> motivated the change and then briefly describing the overall shape of
> the change.  But detailed information should be in the change itself.
> 
> So Alexander, when you're writing future log messages, ask yourself as
> you write "Does any of this information belong in the code instead of in
> the log message?"
> 
> (I did read the rest of this thread, by the way.)
> 
> -Karl
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
> 
> 
> 
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org