Re: svn commit: r31484 - in trunk: . subversion/svn tools/po

On Wed, May 28, 2008 at 11:27:51AM +0200, Erik Huelsmann wrote:
> > > Not sure if you realized this yet, but this change breaks the build on
> > > Win32: http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/463/step-Build/0.
> > > You define the GETTEXT_NOOP macro in configure.ac, which is not used
> > > on Windows.
> >
> If you look at http://svn.collab.net/repos/svn/trunk/subversion/svn_private_config.hw
>
> You'll see what you have to do in order to fix the Windows build.
> (It's at the bottom of the file.)

Thanks, I fixed it in r31491.

> > I search before for definitions of the similar macro N_ and found it
> > only in configure.ac so I added the new macro definition there too.
> > $ trunk> grep -r "define *N_" . | grep -v .svn
> > ./configure.ac:#define N_(x) x

The problem was the wrong grep usage to skip files in .svn/. It should
be grep -v "\.svn".

Jens

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-28 11:56:51 CEST