[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31292 - trunk/subversion/bindings/javahl/native

From: <epg_at_google.com>
Date: Wed, 21 May 2008 13:12:11 -0700

markphip_at_tigris.org writes:

> Author: markphip
> Date: Sun May 18 13:13:33 2008
> New Revision: 31292
>
> Log:
> JavaHL: Followup to r23812. Add Windows SSL certificate
> trust provider support to JavaHL.
>
> [ in subversion/bindings/javahl/ ]
>
> * native/SVNClient.cpp
> (SVNClient::getContext): Use Windows SSL certificate
> trust provider.
>
> Modified:
> trunk/subversion/bindings/javahl/native/SVNClient.cpp
>
> Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native
> /SVNClient.cpp?pathrev=31292&r1=31291&r2=31292
> =============================================================================
> =
> --- trunk/subversion/bindings/javahl/native/SVNClient.cpp Sun May 18 12:4
> 0:54 2008 (r31291)
> +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Sun May 18 13:1
> 3:33 2008 (r31292)
> @@ -1219,6 +1219,10 @@ svn_client_ctx_t *SVNClient::getContext(
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>
> /* The server-cert, client-cert, and client-cert-password providers. */
> +#if defined(WIN32) && !defined(__MINGW32__)
> + svn_auth_get_windows_ssl_server_trust_provider(&provider, pool);
> + APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> +#endif

As far as I could tell when I first started building on Windows,
you can't build svn with mingw. I wish we could, and hope that
will one day change. So, why do you disable this in the mingw
case? I don't see how the tool chain has any impact on this.
When we can build with mingw, the resulting binaries should be
able to talk to the Windows trust store.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-21 22:12:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.