[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] RE: Commit strips common prefix instead of current directory (Issue #3168)

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 14 May 2008 16:29:05 -0400

"Bert Huijben" <bert_at_qqmail.nl> writes:
> Log message for patch 3:
>
> [[[
> Calculate a notify prefix for commit notifications.
>
> * subversion/libsvn_client/commit.c
> (svn_client_commit4): Calculate a new-style notify prefix to pass to
> svn_client__do_commit (no functional change).
>
> Patch by: Bert Huijben <b.huijben_at_competence.biz>
> Tweaked by: kfogel
> ]]]

I just posted a mail about patch 2, saying that it breaks all the
regression tests.

Then when I saw patch 3, I thought "Oh, maybe he just forgot to note in
his log message for patch 2 that it breaks notification paths for commit
and that upcoming patch 3 will fix that". So I applied patch 3 on top
of patch 2, and ran my repro script (http://paste.lisp.org/display/60776),
and the path printed there seemed to be okay.

So then I ran the regression tests again... But they still all fail,
even with both patch 2 and 3 applied.

Obviously, if there is any interdependency between patches (like, one
causes tests to break, but the next one unbreaks them), that should
always be noted in the log message.

But I'm not sure that's going on here, since things still seem to be
broken with patch 3 applied.

Hey, you appear to be in IRC now, I'll go chat there.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-14 22:29:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.