[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_wc_add3(): handles depth on add

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 12 May 2008 09:37:07 -0400

Karl Fogel <kfogel_at_red-bean.com> writes:
> For API compatibility reasons, we have to be careful not to change the
> meaning of svn_client_add3(). The question is, did r26607 already
> change its meaning, and now you're just correcting it back, or was
> r26607 already as correct as we could be?
>
> Consistency with svn/main.c isn't the issue, I think. Consistency with
> the past meaning of the API is what's important.

By the way, I traced svn_client_add3() in 1.4.x and confirmed that it
did treat recursive=false as svn_depth_empty. So I applied your patch
in r31131 and nominated it for backport (with a note that it's only a
nice-to-have, not a must-have, for release -- if this fix came out in
1.5.1 that would be okay too).

Thanks!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-12 15:37:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.