[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_wc_add3(): handles depth on add

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Thu, 08 May 2008 17:45:33 -0400

"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
> svn_add4_cleanup.diff
> [[[
> Some cleanups:
> * subversion/include/svn_client.h, subversion/libsvn_client/add.c
> (svn_client_add4): Fold up duplicated code in both path of a branch
> (svn_client_add3): Map the -N to svn_depth_empty, make it consistent with
> the mapping in svn/main.c
> ]]]

As you can see, I applied the svn_client_add4() part of this in r31102,
but not the svn_client_add3() part.

For API compatibility reasons, we have to be careful not to change the
meaning of svn_client_add3(). The question is, did r26607 already
change its meaning, and now you're just correcting it back, or was
r26607 already as correct as we could be?

Consistency with svn/main.c isn't the issue, I think. Consistency with
the past meaning of the API is what's important.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-08 23:45:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.