Karl Fogel wrote:
> lgo_at_tigris.org writes:
>> Log:
>> ra_serf: Gracefully handle XML parsing errors, instead of aborting.
>>
..
>> svn_ra_serf__list_t *done_reports = NULL;
>> replay_context_t *replay_ctx;
>> + int status_code;
>>
>> /* Send pending requests, if any. Limit the number of outstanding
..>
> It might be worth making a comment where we declare 'status_code' that
> its sole purpose is to be an address so that the
> 'parser_ctx->status_code' field will not be NULL (and therefore the
> parser will not abort on error). Otherwise, the fact that we carefully
> assign status_code's address but never check its value later could be
> confusing.
>
> (Or am I misinterpreting what's going on?)
>
I added the comment in r30992, as you're right in that status_code
doesn't serve any real purpose besides avoiding the abort for now.
> That concern notwithstanding, I've voted for this in 1.5.x/STATUS.
>
Thank you, that's very nice :-)
thanks for the review Karl.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-03 14:56:45 CEST