Re: svn commit: r30685 - branches/svnserve-logging/subversion/svnserve

epg_at_google.com writes:

> +const char *
> +svn_log__change_rev_prop(svn_revnum_t rev, const char *name, apr_pool_t *pool)
> +{
> + return apr_psprintf(pool, "change-rev-prop r%ld %s", rev,
> + /* XXX Why do this and rev_prop (below) encode the
> + property name? Is that really necessary? When I
> + added logging for the log-with-revprops stuff, I
> + didn't encode the revprop names there. Can I stop
> + encoding here and in rev_prop or must I encode in
> + log? */
> + svn_path_uri_encode(name, pool));

Yep, they need to be encoded; see r30689.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-18 22:24:34 CEST