Re: svn commit: r30685 - branches/svnserve-logging/subversion/svnserve

epg_at_tigris.org writes:

> Author: epg
> Date: Fri Apr 18 10:49:34 2008
> New Revision: 30685
>
> Log:
> Fix diff logging. All done now! I can haz reviewz plz?

Easy review command:

  svn diff http://svn.collab.net/repos/svn/trunk@30530 http://svn.collab.net/repos/svn/branches/svnserve-logging

In looking over that myself, I see I still had two questions:

Index: subversion/libsvn_subr/log.c

+const char *
+svn_log__change_rev_prop(svn_revnum_t rev, const char *name, apr_pool_t *pool)
+{
+ return apr_psprintf(pool, "change-rev-prop r%ld %s", rev,
+ /* XXX Why do this and rev_prop (below) encode the
+ property name? Is that really necessary? When I
+ added logging for the log-with-revprops stuff, I
+ didn't encode the revprop names there. Can I stop
+ encoding here and in rev_prop or must I encode in
+ log? */
+ svn_path_uri_encode(name, pool));
+}

+const char *
+svn_log__rev_prop(svn_revnum_t rev, const char *name, apr_pool_t *pool)
+{
+ return apr_psprintf(pool, "rev-prop r%ld %s", rev,
+ /* XXX See change_rev_prop above. */
+ svn_path_uri_encode(name, pool));
+}

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-18 21:34:55 CEST