epg_at_google.com writes:
>> Putting it in a separate file and putting the Apache copyright -- just
>> the Apache copyright, not our own -- at the top of that file would be
>
> I've changed it, so it seems to me we should add our own
> copyright statement as well.
Ah, I didn't realize you'd changed it. Okay, then yeah, I guess both
copyrights apply.
It's too bad, it's the first dual-copyright thing in our core code.
We're okay to distribute, of course, since we're complying with the
license(s). It'll just make things ever-so-slightly messier come CLA
time.
However, I just looked into what would be involved in moving that stuff
over to APR, and it's somewhat hairy (as there are other things
Subversion doesn't use that maybe also should be migrated over, == long
discussion on dev_at_apr). While apr-izing it would be the ideal solution,
I think I'd rather live with the ever-so-slight-messiness for now.
You've carefully left attributions intact, so it's all traceable.
To simplify things a bit, you could get rid of the MAX_STRING_LEN
#define, since we only use it in one of our callers. We could hardcode
it or call it any name we want. It's not like we got the idea of
defining constants from httpd :-), and this way all of our copying would
be confined to httpd/trunk/server/util.c.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-17 18:51:16 CEST