[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use subprocess.Popen for executing commands in cmdline tests

From: Branko ─îibej <brane_at_xbc.nu>
Date: Mon, 07 Apr 2008 11:35:17 +0200

jeremy hinds wrote:
> [[[
> In cmdline tests, use subprocess.Popen for executing commands to allow
> support for exit-code checks on both Windows and posix systems. This makes
> the test suite require Python version >= 2.4.
>

I do have a couple questions.

    * Why run Popen with shell=True? I don't think we need that and can
      avoid all kinds of quoting magic that we do now, since Popen does
      the system-specific argument quoting for us.
    * I /think/ i recall that we have the binary-mode parameter for a
      reason. I don't remember the reason offhand, but just killing off
      that option doesn't seem safe. (FWIW, the reason is most likely
      related to text and binary being different on Windows.)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-07 11:35:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.