[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Use subprocess.Popen for executing commands in cmdline tests

From: jeremy hinds <jeremy.hinds_at_gmail.com>
Date: Sun, 6 Apr 2008 23:50:19 -0600

This was suggested by Branko ╚ibej here:


I don't have a normal Windows development environment set up, so I
haven't actually verified that exit-code testing now works correctly
in non-posix environments. And as mentioned in the log message, this
pushes the Python version required to run the test suite up to 2.4.

In cmdline tests, use subprocess.Popen for executing commands to allow
support for exit-code checks on both Windows and posix systems. This makes
the test suite require Python version >= 2.4.

* subversion/tests/cmdline/svntest/main.py
  (global): Import subprocess instead of popen2. Remove variable
  (open_pipe): Remove "binary_mode" parameter. Use subprocess.Popen for
    spawning the child process.
  (wait_on_pipe): Interpret the return value of wait() according to
    subprocess.Popen semantics.
  (run_command, run_command_stdin, spawn_process): Remove "binary_mode"
    parameter, and do not pass that parameter to run_command_stdin, open_pipe.
  (run_svn, run_svnadmin, run_svnlook, run_svnsync, run_svnversion,
    create_repos, copy_repos, TestSpawningThread.run_one): Do not pass
    "binary_mode" parameter to run_command, open_pipe, or spawn_process.

* subversion/tests/cmdline/svntest/actions.py
  (run_and_verify_svnlook, run_and_verify_svnlook2, run_and_verify_svnadmin,
   run_and_verify_svnadmin2, run_and_verify_svnversion,
   run_and_verify_svnversion2, run_and_verify_svn, run_and_verify_svn2,
   run_and_verify_svn_match_any, run_and_verify_svn_match_any2):
    Remove the caveat comment stating that exit-code checks are skipped
    for some platforms.
  (run_and_verify_load, check_prop): Do not pass the "binary_mode" parameter
    to run_command_stdin or run_command.

* subversion/tests/cmdline/svnadmin_tests.py,
    Do not pass the "binary_mode" parameter to run_command or

Suggested by: brane

Patch by: Jeremy Hinds <jeremy.hinds_at_gmail.com>

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-04-07 07:50:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.