[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29961 - in trunk/subversion: include libsvn_client

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Wed, 02 Apr 2008 13:08:26 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Glasser wrote:
> On Wed, Apr 2, 2008 at 12:10 AM, Bhuvaneswaran Arumugam
> <bhuvan_at_collab.net> wrote:
>> On Wed, 2008-04-02 at 12:31 +0530, Kamesh Jayachandran wrote:
>> > >>
>> > >> * subversion/include/svn_client.h
>> > >> (SVN_CLIENT_IS_WC_DEPENDENT_REVKIND): Move this macro ...
>> > >> * subversion/libsvn_client/client.h
>> > >> (SVN_CLIENT__REVKIND_NEEDS_WC) ... to here and rename it.
>> > >
>> >
>> > I just realized do we need SVN_CLIENT__REVKIND_NEEDS_WC at all as we
>> > already have svn_client__revision_is_local?
>>
>> If i'm right, in SVN_CLIENT__REVKIND_NEEDS_WC macro, we check for
>> following revisions:
>> svn_opt_revision_base
>> svn_opt_revision_previous
>> svn_opt_revision_working
>> svn_opt_revision_committed
>>
>> whereas, in svn_client__revision_is_local() function we check for
>> following revisions:
>> svn_opt_revision_unspecified
>> svn_opt_revision_head
>> svn_opt_revision_number
>> svn_opt_revision_date
>
> Huh. svn_client__revision_is_local is weird. Why wouldn't
> svn_opt_revision_number be "local"? It doesn't require the repository
> to resolve it...

The implementation is kind of negative logic.

As it is not used either we can remove it(after all a intra library
function and our compatibility rules allow it) or we can change its
logic to a positive logic.

With regards
Kamesh Jayachandran
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH8zfm3WHvyO0YTCwRAg2XAJ92cMVw4PibVZCH4ZUAUzn6WmaaaQCdEi7n
F58wdBUCJnM/3uA2ef8wkBA=
=xVtx
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-02 09:39:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.