Re: svn commit: r29961 - in trunk/subversion: include libsvn_client

On Wed, Apr 2, 2008 at 12:10 AM, Bhuvaneswaran Arumugam
<bhuvan_at_collab.net> wrote:
>
> On Wed, 2008-04-02 at 12:31 +0530, Kamesh Jayachandran wrote:
> > >>
> > >> * subversion/include/svn_client.h
> > >> (SVN_CLIENT_IS_WC_DEPENDENT_REVKIND): Move this macro ...
> > >> * subversion/libsvn_client/client.h
> > >> (SVN_CLIENT__REVKIND_NEEDS_WC) ... to here and rename it.
> > >
> >
> > I just realized do we need SVN_CLIENT__REVKIND_NEEDS_WC at all as we
> > already have svn_client__revision_is_local?
>
> If i'm right, in SVN_CLIENT__REVKIND_NEEDS_WC macro, we check for
> following revisions:
> svn_opt_revision_base
> svn_opt_revision_previous
> svn_opt_revision_working
> svn_opt_revision_committed
>
> whereas, in svn_client__revision_is_local() function we check for
> following revisions:
> svn_opt_revision_unspecified
> svn_opt_revision_head
> svn_opt_revision_number
> svn_opt_revision_date

Huh. svn_client__revision_is_local is weird. Why wouldn't
svn_opt_revision_number be "local"? It doesn't require the repository
to resolve it...

Of course, the function isn't actually used any more.

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org