[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Check UUID at RA connection opening

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Wed, 26 Mar 2008 08:08:07 +0200

Karl Fogel wrote on Tue, 25 Mar 2008 at 19:31 -0400:
> Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
>> It does add a round trip over neon, but I suspect it shouldn't.
>>
>> Specifically, the following PROPFIND request, which neon makes early in
>> an 'svn up' connection:
>>
>> <?xml version="1.0" encoding="utf-8"?>
>> <propfind xmlns="DAV:">
>> <prop>
>> <version-controlled-configuration xmlns="DAV:"/>
>> <resourcetype xmlns="DAV:"/>
>> <baseline-relative-path xmlns="http://subversion.tigris.org/xmlns/dav/"/>
>> <repository-uuid xmlns="http://subversion.tigris.org/xmlns/dav/"/>
>> </prop></propfind>
>>
>> is sent twice if the patch is applied, and once if it isn't.
>
> Ah, thanks. Can you make it cache the UUID whenever it first receives
> the UUID? That would solve this.
>

I'll look into it. I see that svn_ra_neon__do_get_uuid() already caches
the UUID; next, I'll find out whether the baseline-relative-path codepath
also caches the UUID (if it sees it).

>> Should this patch go into 1.5.0? I won't have time to set up an Apache
>> build environment in time for the release.
>
> IMHO, no. It's not a 1.5-blocking bug (after all, if we weren't
> checking UUID all this time, then it's not such a big deal if the fix
> comes out in 1.5.1 or 1.6 instead of 1.5).
>
> -Karl
>

Okay.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-26 07:08:37 CET

This is an archived mail posted to the Subversion Dev mailing list.