Re: [PATCH] Check UUID at RA connection opening

Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> It does add a round trip over neon, but I suspect it shouldn't.
>
> Specifically, the following PROPFIND request, which neon makes early in
> an 'svn up' connection:
>
> <?xml version="1.0" encoding="utf-8"?>
> <propfind xmlns="DAV:">
> <prop>
> <version-controlled-configuration xmlns="DAV:"/>
> <resourcetype xmlns="DAV:"/>
> <baseline-relative-path xmlns="http://subversion.tigris.org/xmlns/dav/"/>
> <repository-uuid xmlns="http://subversion.tigris.org/xmlns/dav/"/>
> </prop></propfind>
>
> is sent twice if the patch is applied, and once if it isn't.

Ah, thanks. Can you make it cache the UUID whenever it first receives
the UUID? That would solve this.

> Should this patch go into 1.5.0? I won't have time to set up an Apache
> build environment in time for the release.

IMHO, no. It's not a 1.5-blocking bug (after all, if we weren't
checking UUID all this time, then it's not such a big deal if the fix
comes out in 1.5.1 or 1.6 instead of 1.5).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-26 00:32:03 CET