[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #3071: allow built-in diff to be specified as diff-cmd

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 24 Mar 2008 16:33:22 -0400

Stefan Sperling wrote:
> On Mon, Mar 24, 2008 at 05:05:06AM -0400, Daniel Danger Bentley wrote:
>> Ping.
>>
>> Is there something I can do to help this process along or that I forgot to
>> do initially? Should I pick a reviewer based on revision history?
>
> Since no-one else has commented so far, let me just give you my
> (non-authoritative!) take on the design of your patch.
>
> I think making an empty string carry special semantics is wrong UI design.
> It's not obvious enough.
>
> What would be better IMHO (and various standard UNIX tools do the
> same thing) is adding an additional option that overrides all previous
> --diff-cmd options, and also config file settings.
>
> Maybe --force-internal-diff ?

As a commentary about the proposed UI, I have to agree with Stefan here.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-03-24 21:33:32 CET

This is an archived mail posted to the Subversion Dev mailing list.