Re: [PATCH] issue #3071: allow built-in diff to be specified as diff-cmd
From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 24 Mar 2008 12:01:47 +0100
On Mon, Mar 24, 2008 at 05:05:06AM -0400, Daniel Danger Bentley wrote:
Since no-one else has commented so far, let me just give you my
I think making an empty string carry special semantics is wrong UI design.
What would be better IMHO (and various standard UNIX tools do the
Maybe --force-internal-diff ?
Coding-wise, your patch looks great.
> P.S. One potential objection I could imagine is that this breaks
What should the semantics of editor-cmd "" be?
For diff3, --force-internal-diff3 would be suitable also. If you can
> * subversion/libsvn_client/diff.c
We usually indent log messages like this, using single spaces:
Hope this helps,
-- Stefan Sperling <stsp_at_elego.de> Software Developer elego Software Solutions GmbH HRB 77719 Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96 13355 Berlin Fax: +49 30 23 45 86 95 http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
This is an archived mail posted to the Subversion Dev mailing list.