Re: 1.5 client can't connect to 1.4 svnserve

Stefan Sperling wrote:
> On Fri, Mar 21, 2008 at 09:20:01PM +0100, Stefan Sperling wrote:
>> On Fri, Mar 21, 2008 at 09:10:49PM +0100, Stefan Sperling wrote:
>>> On Fri, Mar 21, 2008 at 08:48:32PM +0100, Stefan Küng wrote:
>>>> file libsvn_ra_svn/client.c, function make_connection():
>>>> if APR_HAVE_IPV6 is defined, then only ipv6 connections are used. If they
>>>> fail, no ipv4 connection is tried before giving up.
>>> Interesting...
>>>
>>> Reading the docstring for apr_sockaddr_info_get in
>>> /usr/local/include/apr-1/apr_network_io.h
>>> makes me believe this could fix it (not tested though...)
>> It likely won't fix it, sorry for the noise:
>>
>> <Bert> stsp: I don't think that will fix it.. getaddrinfo() returns
>> multiple addresses and only one is tried
>> <stsp> oh, right - I thought it failed at "Unkown hostname" but it fails
>> at "Can't connect to host"
>
> OK, next try.
>
> Tested locally with 1.5 svnserve and svn client, on a fully IPv6-enabled
> host (running FreeBSD). Connecting works, and the client errors out
> while svnserve is not running, so at least this patch does not seem
> to break anything.
>
> Stefan, does this fix the issue for you?

Yes, this fixes the problem.
On little detail about your patch: it doesn't compile as it is.
You have to move the variable decl (apr_sockaddr_t *s;) to the start of
the function.

Thanks for fixing this!

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net