Re: 1.5 client can't connect to 1.4 svnserve

On Fri, Mar 21, 2008 at 09:20:01PM +0100, Stefan Sperling wrote:
> On Fri, Mar 21, 2008 at 09:10:49PM +0100, Stefan Sperling wrote:
> > On Fri, Mar 21, 2008 at 08:48:32PM +0100, Stefan Küng wrote:
> > > file libsvn_ra_svn/client.c, function make_connection():
> > > if APR_HAVE_IPV6 is defined, then only ipv6 connections are used. If they
> > > fail, no ipv4 connection is tried before giving up.
> >
> > Interesting...
> >
> > Reading the docstring for apr_sockaddr_info_get in
> > /usr/local/include/apr-1/apr_network_io.h
> > makes me believe this could fix it (not tested though...)
>
> It likely won't fix it, sorry for the noise:
>
> <Bert> stsp: I don't think that will fix it.. getaddrinfo() returns
> multiple addresses and only one is tried
> <stsp> oh, right - I thought it failed at "Unkown hostname" but it fails
> at "Can't connect to host"

OK, next try.

Tested locally with 1.5 svnserve and svn client, on a fully IPv6-enabled
host (running FreeBSD). Connecting works, and the client errors out
while svnserve is not running, so at least this patch does not seem
to break anything.

Stefan, does this fix the issue for you?

[[[

* subversion/libsvn_ra_svn/client.c
  (make_connection): Loop over all available addresses of
   the host to connect to, instead of trying only the first
   and bailing if the host does not accept a connection
   on that address.

]]]

-- 
Stefan Sperling <stsp_at_elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner