[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Issue #3097: svn propget should return non zero code on unknown property

From: jeremy hinds <jeremy.hinds_at_gmail.com>
Date: Wed, 19 Mar 2008 01:08:38 -0600

I don't know if this can be accepted right now. A similar issue for
changing the exit-code behavior for `svn diff`
(http://subversion.tigris.org/issues/show_bug.cgi?id=2513) was
declared an API change that must wait for 2.0. But I figure it can't
hurt to put this out there anyway.

I'm not sure that changing the semantics for errors with an
empty-string messages is the right approach, so I'm open to
suggestions.

[[[
Issue #3097: svn propget should return non zero code on unknown property.

* subversion/libsvn_subr/error.c
  (svn_handle_error2): Don't print error when the message is an empty string.

* subversion/include/svn_error.h
  (svn_handle_error2): Adjust the documentation string.

* subversion/svn/propget-cmd.c
  (svn_cl__propget): Return a silent error if the property is not found on
  any of the targets.

* subversion/tests/cmdline/prop_tests.py
  (props_over_time): Expect exit code of 1 if no property is expected.
  (not_found_exit_failure): New test.
  (test_list): Run it on posix systems.

* subversion/tests/cmdline/copy_tests.py
  (repos_to_wc, copy_added_paths_to_URL, copy_peg_rev_url):
  Expect exit code of 1 from propget.

* subversion/tests/cmdline/merge_tests.py
  (textual_merges_galore, mergeinfo_elision, empty_mergeinfo):
  Expect exit code of 1 from propget.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-03-19 08:08:52 CET

This is an archived mail posted to the Subversion Dev mailing list.