[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] svn log url -rXXX should display proper error message

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: Wed, 19 Mar 2008 10:38:38 +0530


I found this issue while I was investigating the effort involved in
handling multiple working copy targets for 'svn log' command, issue
1550. Right now, if we pass working copy dependent revision kind using
'svn log url_at_REV' command, it displays an error message. Ex:
$ svn log url_at_BASE
svn: Revision type requires a working copy path, not a URL

But, if we pass using 'svn log -rREV url' command, it errors out. Ex:
$ svn log url -rBASE
svn: 'url' is not a working copy
svn: Can't open file 'url/.svn/entries': No such file or directory

Please find attached a patch to handle this case.

If working copy dependent revision kind is used for 'svn log url -rXXX'
command, display an error message. Add svn_opt_revision_working to list
of revision kinds we should check.

* subversion/include/svn_client.h
  (SVN_CLIENT_IS_WC_DEPENDENT_REVKIND): New macro to check if revision
  kind is dependent on working copy. If yes, return TRUE; otherwise,
  return FALSE.
* subversion/libsvn_client/log.c
  (svn_client_log4): Use the new macro. Even if start/end revision kind
  is dependent on working copy, display an error message.

Please review and let me know your comments. Thank you!


Received on 2008-03-19 06:08:53 CET

This is an archived mail posted to the Subversion Dev mailing list.