[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] consistent function formatting for libsvn_ra

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 27 Feb 2008 23:26:50 +0100

On Wed, Feb 27, 2008 at 05:13:55PM -0500, Karl Fogel wrote:
> Stefan Sperling <stsp_at_elego.de> writes:
> > If blame information is really that important, we should scratch the
> > patch altogether. Otherwise I'd still rather opt for consistent style.
> >
> > I stumbled across this because Steve is looking into adding code to
> > one of the files in question, and we could not figure out the correct
> > style to use for new code.
> >
> > So I asked in IRC what style new code should use. Erik Huelsmann said
> > the project was aiming at keeping the style consistent within modules.
> > Since libsvn_ra's style is totally ambiguous, I created the patch to
> > make it consistent.
> >
> > So, for me, it's not about being tidy for the sake of it, but because
> > of the benefits consistency provides when adding or modying code.
>
> I think consistency is worth it too. Maybe apply this after 1.5 is
> released?

I'll bump this thread again when 1.5 is released.

(/me makes a mental note and hopes not to forget about it...)

-- 
Stefan Sperling <stsp_at_elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

  • application/pgp-signature attachment: stored
Received on 2008-02-27 23:27:02 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.