[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] consistent function formatting for libsvn_ra

From: David Glasser <glasser_at_davidglasser.net>
Date: Wed, 27 Feb 2008 14:24:17 -0800

On Wed, Feb 27, 2008 at 2:13 PM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> Stefan Sperling <stsp_at_elego.de> writes:
> > If blame information is really that important, we should scratch the
> > patch altogether. Otherwise I'd still rather opt for consistent style.
> >
> > I stumbled across this because Steve is looking into adding code to
> > one of the files in question, and we could not figure out the correct
> > style to use for new code.
> >
> > So I asked in IRC what style new code should use. Erik Huelsmann said
> > the project was aiming at keeping the style consistent within modules.
> > Since libsvn_ra's style is totally ambiguous, I created the patch to
> > make it consistent.
> >
> > So, for me, it's not about being tidy for the sake of it, but because
> > of the benefits consistency provides when adding or modying code.
> I think consistency is worth it too. Maybe apply this after 1.5 is
> released?

We really don't change the RA loader *that* often. How many RA *API*
changes do you expect will show up in 1.5 that we haven't done yet? I
think this is fine for trunk now.


David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-27 23:24:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.