[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Issue #2381 - Cannot commit multiple WC paths which lack a common parent directory

From: Chris Rose <chris.rose_at_messagingdirect.com>
Date: Tue, 26 Feb 2008 16:21:42 -0700

I'm interested in tackling this issue, but there's a lack of explanation
in commit.c as to why we need to lock the parent directory at all.

To clarify, here's my scenario:

We often have checked out working copies that are checked out into a
non-wc directory. They all come from the same repository, however, and
therefore it should be reasonable that we could commit changes in more
than one of them in one commit. So, this appears to match the issue in
question.

What I'm not sure of is _why_ we lock the parent directory at all; it's
clear that it's happening, it's just not clear why or what we need to do
with it. It seems to me that once we have a set of targets, if they
_do_ live inside other working copies it makes sense to lock those, but
if they do not then it's not necessary. Am I correct in this assumption?

So, my proposed change would be to build a list of candidate base dirs
instead of a single one, and lock those that have a working copy
administrative area, ignoring the ones that don't.

Assuming this to be the case, I believe that the commit_test.py test #
25 verifies this, so I just need to reverse the test case on it to
validate a positive test.

Opinions?

-- 
Chris Rose
Developer    Planet Consulting Group
(780) 577-8433
crose_at_planetci.com

Received on 2008-02-27 00:22:20 CET

This is an archived mail posted to the Subversion Dev mailing list.