Re: [PATCH] Followup to r29374.

Hi Kamesh,

Kamesh Jayachandran wrote:
> Please find my comments below,

Thank You for your comments.

> If we love abstracting this data-type we need to provide its own
> accessor routines i.e we should not blatantly use apr_hash_get/set.

Yes I get your point here.

>> Index: subversion/bindings/swig/core.i
>> ===================================================================
>> --- subversion/bindings/swig/core.i (revision 29523)
>> +++ subversion/bindings/swig/core.i (working copy)
>> @@ -264,16 +264,16 @@
>> /*
>> -----------------------------------------------------------------------
>> input mergeinfo hash
>> */
>> -%apply apr_hash_t *MERGEINFO {
>> - apr_hash_t *mergefrom,
>> - apr_hash_t *mergeto,
>> - apr_hash_t *mergein1,
>> - apr_hash_t *mergein2,
>> - apr_hash_t *mergeinfo,
>> - apr_hash_t *mergeinput,
>> - apr_hash_t *eraser,
>> - apr_hash_t *whiteboard,
>> - apr_hash_t *changes
>> +%apply svn_mergeinfo_t *MERGEINFO {
>> + svn_mergeinfo_t *mergefrom,
>> + svn_mergeinfo_t *mergeto,
>> + svn_mergeinfo_t *mergein1,
>> + svn_mergeinfo_t *mergein2,
>> + svn_mergeinfo_t *mergeinfo,
>> + svn_mergeinfo_t *mergeinput,
>> + svn_mergeinfo_t *eraser,
> I don't know much of bindings, but your change is 'type-wise totally
> wrong in this file', you are replacing 'apr_hash_t *mergefrom' with
> 'svn_mergeinfo_t *mergefrom' which should have been 'svn_mergeinfo_t
> mergefrom'.

Aw, I missed it. I am unaware of the methods of testing swig bindings, so
didn't come to my notice when I ran the tests.

-- 
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org