[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Who maintains asvn? What is the status of asvn?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Sun, 27 Jan 2008 23:53:39 +0000

Paul Albrecht wrote:
> On Wed, 2008-01-23 at 07:21 -0800, Blair Zajac wrote:
>
>>Paul Albrecht wrote:
>>>Who maintains asvn? What is the status of asvn?
>>
>>Anything checked into the svn repository is owned by the entire development
>>team. asvn is located in contrib/client-side/asvn, so it's contributed to svn
>>and has no official support by the subversion developers.
>>
>>If you want to send in patches, read this document: [...]
>
> Thanks for the pointers, but they're not really helpful. Specifically,
> what I'm interested in is why a patch for asvn submitted to this list
> last December--it fixed the problem handling file names with embedded
> spaces--wasn't applied to contrib/client-side/asvn.

Hi Paul.

I've looked for the patch you refer to, and found the email here:
   <http://svn.haxx.se/dev/archive-2007-12/0617.shtml> and
   <http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=133783>
(in the former archive, spacing is wrong; in the latter, spacing is correct but
tab characters are expanded - so neither is good for applying the patch).

I think I can see why it wasn't applied: it doesn't make it easy for any
committer to quickly deal with it (see the patch submission guidelines that
Blair pointed to), and it caught no-one's interest.

That happens on a volunteer-based project fairly often, and it's right to prod
us again after seeing no satisfactory response for a few days.

In this case, I tried extracting the patch from the email archive, re-tabifying
it, and applying it, but it didn't go smoothly. In the end I got it patched and
checked that it at least partly runs in some random scenario; not properly
reviewed or tested.

Anyway I have committed it now as r29062.

Thanks for bringing the patch to our attention.

===

One potential problem I spotted was the quoting (especially the odd number of
single quotes) in line 293:

- dest=`expr "$info" : ".*' dest='\(.*\)'$"`
+ dest="`expr \"$info\" : \".*' dest='\(.*\)'$\"`"

Vim's syntax highlighting shows this as wrong, though you can't trust syntax
highlighting for a definitive answer.

But if this is wrong it was already wrong before this patch. In my quick tests
I was unable to find a scenario that would exercise this code path.

Regards,
- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-28 00:53:55 CET

This is an archived mail posted to the Subversion Dev mailing list.