Re: [PATCH] Fix copyright years in header files

2008-01-27 02:59:09 Hyrum K. Wright napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote:
> > 2008-01-27 00:12:28 Hyrum K. Wright napisał(a):
> >> Arfrever Frehtes Taifersar Arahesis wrote:
> >>> [[[
> >>> * subversion/include/private/svn_atomic.h:
> >>> * subversion/include/private/svn_dep_compat.h:
> >>> * subversion/include/private/svn_wc_private.h:
> >>> * subversion/include/svn_auth.h:
> >>> * subversion/include/svn_cmdline.h:
> >>> * subversion/include/svn_ctype.h:
> >>> * subversion/include/svn_error_codes.h:
> >>> * subversion/include/svn_error.h:
> >>> * subversion/include/svn_hash.h:
> >>> * subversion/include/svn_md5.h:
> >>> * subversion/include/svn_opt.h:
> >>> * subversion/include/svn_path.h:
> >>> * subversion/include/svn_props.h:
> >>> * subversion/include/svn_ra_svn.h:
> >>> * subversion/include/svn_sorts.h:
> >>> * subversion/include/svn_string.h:
> >>> * subversion/include/svn_subst.h:
> >>> * subversion/include/svn_user.h:
> >>> * subversion/include/svn_utf.h:
> >>> * subversion/include/svn_version.h:
> >>> * subversion/include/svn_wc.h:
> >>> * subversion/svn_private_config.hw:
> >>> Fix copyright years in header files.
> >>> ]]]
> >>>
> >>> If a file was modified in 2004, 2005, 2006 and 2008, should the copyright years
> >>> be written as "2004-2006, 2008" or "2004-2008"?
> >> Have all of these files been modified in 2008? If not, it would be
> >> inappropriate to claim a copyright date of 2008 on them.
> >
> > This patch doesn't claim a copyright date of 2008 on all of these files.
> > It's usually 2007. But please just read this patch.
>
> I apologize if my comment was a bit hasty. I wasn't reviewing the
> implementation of the patch, simply the concept, which should be clear
> from the log message. The only thing I saw was "Fix copyright years",
> which in my mind implies bringing copyright year ranges up-to-date to
> the current year.
>
> Would I be right in thinking that your change really means:
> Update copyright years to reflect dates of modification.

Yes. I also ommitted changes in comments/documentation.

-- 
Arfrever Frehtes Taifersar Arahesis