[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28768 - in branches/issue-2897/subversion: libsvn_client tests/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Sat, 26 Jan 2008 21:35:23 +0000

Kamesh Jayachandran wrote:
> Daniel Rall wrote:
>>--- branches/issue-2897/subversion/libsvn_client/merge.c (original)
>>+++ branches/issue-2897/subversion/libsvn_client/merge.c Mon Jan 7 07:32:32 2008
>>+summarize_reflected_ranges(svn_depth_t depth,
>>+ merge_cmd_baton_t *merge_b)
>>+{
>> This is also going to be a potentially really expensive operation, and
>> should be documented as such in the API's doc string.
>
> I agree it is expensive, we run such summaries *only* for reflective
> revisions *not always*. How come documenting it helps?

Most of Subversion is fast and efficient. Wherever we know that a Subversion
API can behave in an unexpected or undesirable way, we aim to tell the API user
so that they will not be surprised and can make an informed choice of whether
to use it, or find a different way, or try to improve the implementation,
without having to read and understand all of the code. For example, the user
might want to display a progress indicator if calling this in a loop. And it
will help the programmer who next reads this code to understand that the
expensive operation is a known disadvantage that we have accepted for the time
being, not something that we accidentally allowed to happen.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-26 22:35:39 CET

This is an archived mail posted to the Subversion Dev mailing list.