[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Pass copy_tests 48: copy added uncommitted paths with props

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 25 Jan 2008 22:03:42 +0200 (Jerusalem Standard Time)

Good morning all,

[[[
Fix copy_tests #48: copy added uncommitted paths with props.

* subversion/libsvn_wc/copy.c
  (copy_props): New function.
  (copy_added_file_administratively):
    Add 'src_access' parameter.
    Copy src's properties to target.
  (copy_added_dir_administratively):
    Copy src's properties to target.
  (copy_added_dir_administratively, svn_wc_copy2):
    Pass 'src_access' to copy_added_file_administratively().

* subversion/tests/cmdline/copy_tests.py
  (copy_added_paths_with_props):
    Expect empty mergeinfo on copy targets.
  (test_list):
    Remove XFail from copy_added_paths_with_props().
]]]

Notes:

1. I changed the test to expect (empty) mergeinfo on the copy targets
because doing so made it pass; I don't know whether it is the correct
expectation. (Is mergeinfo meaningful on a schedule-add file?)

2. The new copy_props() function is similar to update_editor.c's
copy_regular_props(), except that the former works with wc entries
(svn_wc_prop_set2) and the latter with abstract property hashes
(apr_hash_set).

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-01-25 21:04:05 CET

This is an archived mail posted to the Subversion Dev mailing list.